Handle empty positions in getAddressIndex #19123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
reviewed
Sep 22, 2023
| @@ -6442,6 +6443,30 @@ public void testMergeSimpleQueryPartitioned() | |||
| assertUpdate("DROP TABLE " + targetTable); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testMergeWithSubselectWithoutHash() | |||
There was a problem hiding this comment.
No need to add a new test.
Just change the existing tests where we enable the optimization manually to work around the bug. Search for references to the github issue in the codebase to find the call sites.
There was a problem hiding this comment.
Okay, I dropped this test + removed the optimize_hash_generation overrides in two tests marked with the issue number.
lukasz-stec
force-pushed
the
ls/2309/002-join-null-positions
branch
from
2458ab2 to
1809759
Compare
lukasz-stec
force-pushed
the
ls/2309/002-join-null-positions
branch
from
1809759 to
2ecb279
Compare
wendigo
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
fixes #19112
Release notes
( X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: