Add docs for MySQL timestamptz handling #19231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
approved these changes
Oct 2, 2023
Comment on lines
282
to
284
| To preserve time instants, Trino's use of the MySQL JDBC driver sets the JVM | ||
| time zone as the session zone and forces the server's time zone to match the | ||
| JVM time zone. Because of this, users may experience an issue if the JVM time |
There was a problem hiding this comment.
I'm not a native English speaker, but the order of this sentence makes it hard to understand. How about this?
Suggested change
| To preserve time instants, Trino's use of the MySQL JDBC driver sets the JVM | |
| time zone as the session zone and forces the server's time zone to match the | |
| JVM time zone. Because of this, users may experience an issue if the JVM time | |
| To preserve time instants, Trino sets the session time zone | |
| of the MySQL connection to match the JVM time zone. | |
| Because of this, users may experience an issue if the JVM time |
There was a problem hiding this comment.
This is much more clear, thank you.
adamjshook
force-pushed
the
adamjshook/trino-timestamp-doc
branch
from
f120e18 to
73d3a9f
Compare
mosabua
requested changes
Oct 5, 2023
| @@ -276,6 +276,22 @@ this table: | |||
|
|
|||
| No other types are supported. | |||
|
|
|||
| ### Timestamp type handling | |||
|
|
|||
| MySQL `TIMESTAMP` types with are mapped to a Trino `TIMESTAMP WITH TIME ZONE`. | |||
There was a problem hiding this comment.
Suggested change
| MySQL `TIMESTAMP` types with are mapped to a Trino `TIMESTAMP WITH TIME ZONE`. | |
| MySQL `TIMESTAMP` types are mapped to Trino `TIMESTAMP WITH TIME ZONE`. |
| MySQL `TIMESTAMP` types with are mapped to a Trino `TIMESTAMP WITH TIME ZONE`. | ||
| To preserve time instants, Trino sets the session time zone | ||
| of the MySQL connection to match the JVM time zone. | ||
| Because of this, users may experience an issue if the JVM time |
There was a problem hiding this comment.
Suggested change
| Because of this, users may experience an issue if the JVM time | |
| As a result, error messages similar to the following example occur when a timezone from the JVM does not exist on the MySQL server: |
| To preserve time instants, Trino sets the session time zone | ||
| of the MySQL connection to match the JVM time zone. | ||
| Because of this, users may experience an issue if the JVM time | ||
| zone does not exist on the MySQL server, receiving an error similar to: |
| com.mysql.cj.exceptions.CJException: Unknown or incorrect time zone: 'UTC' | ||
| ``` | ||
|
|
||
| Users will need to use a time zone that is known to both the JVM and MySQL, |
There was a problem hiding this comment.
Replacement paragraph.
To avoid the errors, you must use a time zone that is known on both systems, or [install the missing time zone on the MySQL server](https://dev.mysql.com/doc/refman/8.0/en/time-zone-support.html#time-zone-installation).
73d3a9f to
cece6f7
Compare
This adds a note in the MySQL connector documentation about an error users may experience when using timestamptz types due to mismatches between JVM time zone and what is installed on the MySQL server.
adamjshook
force-pushed
the
adamjshook/trino-timestamp-doc
branch
from
cece6f7 to
6c455da
Compare
mosabua
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a note in the MySQL connector documentation about an error users may experience when using timestamptz types due to mismatches between JVM/time zone and what is installed on the MySQL server.
Additional context and related issues
Relates to #18470
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: