-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require JDK 21 to run Trino #20010
Require JDK 21 to run Trino #20010
Conversation
808ceb8
to
b7b76fc
Compare
1602af5
to
15bca03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content changes look good. Need confirmation that the jvm.config should stay as is in the docs and other resources.
And then we need the confidence to merge this in as a hard requirement. I have not heard anything about problems with the docker container or in general about 21 at this stage.
Just fyi .. for Trino Summit keynote next Wednesday we are going to announce this as merged or as pending and request more feedback. Either is fine .. just @martint and myself need to know so we can adjust slide deck accordingly |
@mosabua do we plan to make a release next week? |
Probably yes .. there are a bunch of things that need to be fixed from what I understand from @martint .. and I am not sure if we should merge this PR or wait another release or two for feedback. The summit would be a good way to announce a last time that we are looking for input. |
@mosabua i'd want to merge this in a new year so let's ask for feedback |
So basically in 2-3 releases from now |
15bca03
to
047c4ec
Compare
047c4ec
to
d7f56b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not heard anything further from any community members that would block this upgrade. I think we should go ahead.
Release notes needed:
Closes #17017