-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip unsupported type widening columns #22458
Merged
ebyhr
merged 2 commits into
trinodb:master
from
SemionPar:semionpar/delta-type-widening-skipping
Jul 24, 2024
Merged
Skip unsupported type widening columns #22458
ebyhr
merged 2 commits into
trinodb:master
from
SemionPar:semionpar/delta-type-widening-skipping
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SemionPar
force-pushed
the
semionpar/delta-type-widening-skipping
branch
from
June 20, 2024 16:54
fb27697
to
ffb5ee2
Compare
While testing nested types I discovered that for {
"type": "struct",
"fields": [
{
"name": "s",
"type": {
"type": "struct",
"fields": [
{
"name": "field",
"type": "double",
"nullable": true,
"metadata": {
"delta.typeChanges": [
{
"toType": "short",
"fromType": "byte",
"tableVersion": 2
},
{
"toType": "double",
"fromType": "short",
"tableVersion": 7
}
]
}
}
]
},
"nullable": true,
"metadata": {}
}, VS {
"name": "a",
"type": {
"type": "array",
"elementType": "double",
"containsNull": true
},
"nullable": true,
"metadata": {
"delta.typeChanges": [
{
"toType": "short",
"fromType": "byte",
"tableVersion": 5,
"fieldPath": "element"
},
{
"toType": "double",
"fromType": "short",
"tableVersion": 10,
"fieldPath": "element"
}
]
}
} I will initially implement skipping of the whole struct if one of the fields type widening is not supported. |
SemionPar
force-pushed
the
semionpar/delta-type-widening-skipping
branch
2 times, most recently
from
July 1, 2024 15:56
1a16d7f
to
d3fddef
Compare
SemionPar
commented
Jul 2, 2024
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Show resolved
Hide resolved
SemionPar
force-pushed
the
semionpar/delta-type-widening-skipping
branch
3 times, most recently
from
July 12, 2024 16:30
419ea35
to
3059148
Compare
SemionPar
changed the title
[draft] Skip unsupported type widening columns
Skip unsupported type widening columns
Jul 12, 2024
SemionPar
force-pushed
the
semionpar/delta-type-widening-skipping
branch
from
July 15, 2024 11:56
3059148
to
3feada2
Compare
nineinchnick
approved these changes
Jul 15, 2024
...elta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeSchemaSupport.java
Outdated
Show resolved
Hide resolved
...-lake/src/test/java/io/trino/plugin/deltalake/transactionlog/TestDeltaLakeSchemaSupport.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Jul 16, 2024
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Outdated
Show resolved
Hide resolved
...elta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeSchemaSupport.java
Outdated
Show resolved
Hide resolved
SemionPar
force-pushed
the
semionpar/delta-type-widening-skipping
branch
2 times, most recently
from
July 16, 2024 16:11
0a5d7b4
to
04facb8
Compare
findinpath
reviewed
Jul 17, 2024
...-lake/src/test/java/io/trino/plugin/deltalake/transactionlog/TestDeltaLakeSchemaSupport.java
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/resources/databricks153/type_widening_partition/README.md
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Outdated
Show resolved
Hide resolved
...elta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeSchemaSupport.java
Show resolved
Hide resolved
findinpath
reviewed
Jul 17, 2024
plugin/trino-delta-lake/src/test/resources/databricks153/type_widening/README.md
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 17, 2024
...elta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeSchemaSupport.java
Outdated
Show resolved
Hide resolved
SemionPar
force-pushed
the
semionpar/delta-type-widening-skipping
branch
from
July 17, 2024 16:51
04facb8
to
e5d2cab
Compare
findinpath
approved these changes
Jul 18, 2024
ebyhr
approved these changes
Jul 19, 2024
...elta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeSchemaSupport.java
Outdated
Show resolved
Hide resolved
...elta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeSchemaSupport.java
Outdated
Show resolved
Hide resolved
...-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TransactionLogParser.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/resources/databricks153/type_widening_partition/README.md
Outdated
Show resolved
Hide resolved
SemionPar
force-pushed
the
semionpar/delta-type-widening-skipping
branch
from
July 19, 2024 14:54
ba9c62a
to
a04cd3b
Compare
Squashed commits. |
ebyhr
reviewed
Jul 22, 2024
...elta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeSchemaSupport.java
Outdated
Show resolved
Hide resolved
A change from failing to skipping is for flexibility, because Databricks supports wider variety of type changes.
Now it also signifies unsupported type widening errors.
SemionPar
force-pushed
the
semionpar/delta-type-widening-skipping
branch
from
July 23, 2024 12:01
a04cd3b
to
f084b1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A change from failing to skipping is for flexibility, because Databricks supports wider variety of type changes.
Draft todos:
Additional context and related issues
#22142, fixes #22433
Release notes