Fix incorrect dedup of non-deterministic functions #22686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
force-pushed
the
random
branch
3 times, most recently
from
73f0065
to
9d14a9c
Compare
hashhar
approved these changes
Jul 17, 2024
The abstraction for validating the IR is brittle, as it depends on details of how QueryAssertions constructs the underlying query. We remove it from the QueryAssertions API for now. Additionally, clean up the tests in TestJsonStringArrayExtractScalar, which were unnecessarily complex.
Non-determinism depends on the body of the lambda expressions passed to the function. That's handled elsewhere.
|
@hashhar, I made a few additional changes. Mind taking a look again? |
hashhar
approved these changes
Jul 18, 2024
core/trino-main/src/main/java/io/trino/operator/scalar/ArrayReduceFunction.java
Show resolved
Hide resolved
hashhar
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22683
Release notes
(x) Release notes are required, with the following suggested text: