Expose ExchangeSource metrics in query json #22722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
force-pushed
the
lo/fte-exchange-metrics2
branch
from
76e6025
to
a99d311
Compare
wendigo
approved these changes
Jul 18, 2024
core/trino-main/src/main/java/io/trino/operator/PipelineContext.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/exchange/ExchangeSource.java
Outdated
Show resolved
Hide resolved
.../main/java/io/trino/plugin/exchange/filesystem/azure/AzureBlobFileSystemExchangeStorage.java
Outdated
Show resolved
Hide resolved
Allow setting pipeline level metrics in PipelineContext. Metrics are keyed on operartor id and will be part of OperatorStats in query JSON. The usecase is to track metrics for entities which are operator specific but shared between operators in given pipeline.
Expose metrics from ExchangeDataSource and pass those externally as metrics of ExchangeOperator
losipiuk
force-pushed
the
lo/fte-exchange-metrics2
branch
from
482985a
to
8f03537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose ExchangeSource metrics in query json
Another approach after reverting #22685.
This time we introduce pipelineOperatorMetrics with explicit property of being shared between all the operator instances for given operator id within a pipeline.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: