Fix flaky TestIcebergMinioOrcConnectorTest #22773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In concurrent mode, testOptimizeTimePartitionedTable is failing intermittently, where there's a congestion on HTTP connections in the S3 client. Switching to a single thread doesn't make the tests slower.
|
Note, the test I updated uses MinIO, so there's no need for running all tests with secrets. |
wendigo
approved these changes
Jul 23, 2024
|
@nineinchnick ping me once it's green |
|
@nineinchnick still failing |
The limit was decreased in a33044e, but it's too low. It's causing a congestion when working with Iceberg manifest files during optimize. Revert it back to the previous value.
nineinchnick
changed the title
|
@nineinchnick can you stress test this change? |
nineinchnick
force-pushed
the
fix-flaky-optimize-partitioned
branch
from
3851fb6
to
7c83dbe
Compare
|
All failed successfully I see :) |
nineinchnick
force-pushed
the
fix-flaky-optimize-partitioned
branch
from
7c83dbe
to
948de9b
Compare
wendigo
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestIcebergMinioOrcConnectorTest.testOptimizeTimePartitionedTableis failing intermittently, where there's a congestion on HTTP connections in the S3 client. Slightly increasing the number of available connections should fix it.Switching to a single thread doesn't make the tests slower.
Fixes #21736
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: