Fix past table versions listing in vacuum procedure #22816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When listing past table versions, correctly break iteration once we get to a file which no longer exists, e.g. removed by an external system. Co-authored-by: Marius Grama <findinpath@gmail.com>
findinpath
approved these changes
Jul 25, 2024
wendigo
approved these changes
Jul 25, 2024
ebyhr
approved these changes
Jul 25, 2024
| assertQuery("SELECT * FROM " + tableName, "VALUES 2, 3"); | ||
| Set<String> updatedFiles = getActiveFiles(tableName); | ||
|
|
||
| assertUpdate("CALL system.vacuum(schema_name => CURRENT_SCHEMA, table_name => '" + tableName + "', retention => '7d')"); |
There was a problem hiding this comment.
No requested change. We could simply named arguments:
assertUpdate("CALL system.vacuum(CURRENT_SCHEMA, '" + tableName + "', '7d')");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When listing past table versions, correctly break iteration once we get to a file which no longer exists, e.g. removed by an external system.
Additional context and related issues
Motivation: vacuum procedure call would otherwise fail with
NullPointerExceptionwhen setting the retention to a value which overlaps with externally deleted log file.Release notes