Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cassandra execute procedure docs #22820

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Jul 25, 2024

Description

  • In Cassandra connector
  • Consistent placement and text with other connectors

Additional context and related issues

Follow up to #22736, #22803, and #22730

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jul 25, 2024
@github-actions github-actions bot added the docs label Jul 25, 2024
@mosabua mosabua changed the title Improve exeecute procedure docs Improve execute procedure docs Jul 25, 2024
@mosabua mosabua requested review from ebyhr and senlizishi July 25, 2024 22:26
@ebyhr ebyhr changed the title Improve execute procedure docs Improve Cassandra execute procedure docs Jul 26, 2024
- Rename fragment to be generic, not jdbc focussed
- Use in Cassandra connector
- Consistent placement and text in Cassandra with other connectors
@mosabua
Copy link
Member Author

mosabua commented Jul 29, 2024

Btw. @ebyhr .. do you think the flush meta data procedure fragment should be renamed as well .. I kinda think yes. And maybe subsequently even be reused in Hive, Delta Lake and such as well? Or is the implementation too different?

In either case.. I think that would belong in a separate PR...

@mosabua mosabua merged commit 0d0f7c0 into trinodb:master Jul 29, 2024
9 checks passed
@mosabua mosabua deleted the cass branch July 29, 2024 23:32
@github-actions github-actions bot added this to the 454 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants