Do not retry fatal errors #23040
Merged
Do not retry fatal errors #23040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we may know that retrying a task does not make sense. We express this information via fatal flag in ErrorCode. If TrinoException is observed with fatal error code query/task will not be retried even if retry_policy is not NONE.
We are not able to retry commiting an iceberg transaction
losipiuk
force-pushed
the
lukaszos/treat-iceberg-commit-error-as-fatal-error-5e452d
branch
from
80cd77a
to
97b3956
Compare
findinpath
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes we may know that retrying a task does not make sense.
We express this information via fatal flag in ErrorCode. If
TrinoException is observed with fatal error code query/task will not be
retried even if retry_policy is not NONE.
extracted from: #23019
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: