Use CatalogStoreManager to load all catalog stores #23115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
force-pushed
the
hashhar/catalog-store-loader
branch
2 times, most recently
from
02322ff
to
2ec5788
Compare
hashhar
force-pushed
the
hashhar/catalog-store-loader
branch
from
2ec5788
to
33cf060
Compare
This change makes the CatalogStoreManager handle IOException when reading config files similar to other managers like AccessControlManager.
hashhar
force-pushed
the
hashhar/catalog-store-loader
branch
from
33cf060
to
d1b4e72
Compare
|
Rebased on master after merging #22886. Will merge once CI is done. |
piotrrzysko
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #22886 so only review commits AFTER "Allow using custom catalog store with TestingTrinoServer"
Description
Before this change we bound file and memory catalog stores directly instead of using the SPI we provide which meant that we had no test coverage for the SPI itself and that the built-in ones were treated differently.
Additional context and related issues
Built on top of #22886 so only review last 2 commits.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: