feat(hive-connector): update the "transient_lastDdlTime" property upon data modification #23134
Conversation
…n data modification Signed-off-by: predator4ann <yunlong.sun@hotmail.com>
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
| Map<String, String> parameters = updateKeyWithTimestamp(modifiedPartition.getParameters(), TRANSIENT_LAST_DDL_TIME); | ||
| modifiedPartition.setParameters(updateStatisticsParameters(parameters, basicStatistics)); |
There was a problem hiding this comment.
Should we handle it out here ? Doesn't HMS handles it out at their end ? Can we have some test cases which validates this behavior ?
There was a problem hiding this comment.
Thank you for your response. After verification, I found that there's no existing API in Metastore to accomplish this task. And I will add test cases later.
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
Description
In our current setup, the 'transient_lastDdlTime' property in the metastore gets updated when data is updated through Hive. This applies to table properties in non-partitioned tables and partition properties in partitioned tables. It's critical to maintain this property when data is updated via Trino.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: