Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove import of Builder #232

Merged

Conversation

findepi
Copy link
Member

@findepi findepi commented Feb 13, 2019

No description provided.

Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this to our list of banned imports

@electrum
Copy link
Member

Filed airlift/airbase#180

You could also remove static import of builder (the method)

@findepi findepi force-pushed the findepi/master/remove-import-of-builder-6c7c88 branch from 518e397 to 33eb662 Compare February 14, 2019 08:27
@@ -30,8 +31,6 @@

import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkState;
import static com.google.common.collect.ImmutableList.Builder;
Copy link
Member Author

@findepi findepi Feb 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know both are valid Java:

import static com.google.common.collect.ImmutableList.Builder;
import        com.google.common.collect.ImmutableList.Builder;

@findepi
Copy link
Member Author

findepi commented Feb 14, 2019

You could also remove static import of builder (the method)

done

@findepi findepi merged commit 7c1f7d4 into trinodb:master Feb 14, 2019
@findepi findepi deleted the findepi/master/remove-import-of-builder-6c7c88 branch February 14, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants