Use drop and create to replace a function on Hive Metastore #24010
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hive 3 does not actually replace the content of the function https://github.com/apache/hive/blob/rel/release-3.1.2/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L9310
findinpath
commented
Nov 2, 2024
| // Hive 3 does not actually replace the content of the function | ||
| // https://github.com/apache/hive/blob/rel/release-3.1.2/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L9310 | ||
| // Fall back to use drop & create for doing the replace function operation | ||
| dropFunction(function.getDbName(), function.getFunctionName()); |
There was a problem hiding this comment.
Another alternative would be to throw an NOT_SUPPORTED TrinoException in io.trino.plugin.hive.metastore.thrift.BridgingHiveMetastore#replaceFunction but this would make the CREATE OR REPLACE a bit cumbersome - it would succeed when the function does not exist and it would fail when the function already exists.
electrum
approved these changes
Nov 3, 2024
ebyhr
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hive 3 does not actually replace the content of the function
https://github.com/apache/hive/blob/rel/release-3.1.2/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L9310
Fall-back to using two operations: drop function followed create function for effectively handling the replace operation for the function when working with Hive Metastore.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: