Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting extra properties in Iceberg #24031

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Support setting extra properties in Iceberg #24031

merged 3 commits into from
Nov 5, 2024
+49 −9

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Nov 5, 2024 •
edited
Loading

Description

Follow-up of #20393

Release notes

## Iceberg
* Add support for setting `extra_properties` table property. ({issue}`24031`)

@cla-bot cla-bot bot added the cla-signed label Nov 5, 2024
@github-actions github-actions bot added the iceberg Iceberg connector label Nov 5, 2024
@ebyhr ebyhr requested a review from sopel39 November 5, 2024 06:28
sopel39
sopel39 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. Thanks!

@sopel39
Copy link
Member

sopel39 commented Nov 5, 2024

cc @osscm

@ebyhr ebyhr merged commit 3b4a388 into trinodb:master Nov 5, 2024
43 checks passed
@ebyhr ebyhr deleted the ebi/iceberg-set-extra-table-properties branch November 5, 2024 22:38
@github-actions github-actions bot added this to the 465 milestone Nov 5, 2024
@mosabua mosabua mentioned this pull request Nov 6, 2024
Open
@lozbrown
Copy link

@ebyhr does this allow users to set identifier fields

https://iceberg.apache.org/spec/#identifier-field-ids

@hashhar hashhar mentioned this pull request Nov 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayankvadariya mayankvadariya mayankvadariya approved these changes

@anusudarsan anusudarsan anusudarsan approved these changes

@sopel39 sopel39 sopel39 approved these changes

Assignees
No one assigned
Labels
cla-signed iceberg Iceberg connector
Milestone
465
Development

Successfully merging this pull request may close these issues.
5 participants
@ebyhr @sopel39 @lozbrown @anusudarsan @mayankvadariya