Allow configuring locale in the Faker connector #24152
Merged
+87
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Nov 18, 2024
plugin/trino-faker/src/test/java/io/trino/plugin/faker/FakerQueryRunner.java
Outdated
Show resolved
Hide resolved
nineinchnick
force-pushed
the
faker-locale
branch
from
2930757
to
34746a4
Compare
raunaqmorarka
approved these changes
Nov 18, 2024
mosabua
reviewed
Nov 18, 2024
| @@ -21,6 +21,7 @@ For example, to generate data in the `generator` catalog, create the file | |||
| connector.name=faker | |||
| faker.null-probability=0.1 | |||
| faker.default-limit=1000 | |||
| faker.locale=pl-PL | |||
There was a problem hiding this comment.
well.. thats kinda a bad example if the default is just "en" ... maybe we should add more examples then .. like en-CA or whatever
mosabua
reviewed
Nov 18, 2024
| @@ -46,6 +47,9 @@ The following table details all general configuration properties: | |||
| that allows them. Defaults to `0.5`. | |||
| * - `faker.default-limit` | |||
| - Default number of rows in a table. Defaults to `1000`. | |||
| * - `faker.locale` | |||
| - Default locale for generating character based data, specified as a IETF BCP | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow configuring locale in the Faker connector.
Release notes