Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable HTTP/2 for internal communication" #24458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Dec 12, 2024

This reverts commit 59ac727.

Jetty was updated to 12.0.16 which should solve HTTP/2 error handling.

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Dec 12, 2024
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to title this "Re-enable HTTP/2 for internal communication" as this reads like a revert-of-a-revert

@electrum
Copy link
Member

Also, I'm excited that we're trying this again!

Copy link

github-actions bot commented Jan 3, 2025

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

@github-actions github-actions bot added the stale label Jan 3, 2025
Copy link

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Jan 24, 2025
@wendigo wendigo reopened this Jan 24, 2025
@mosabua mosabua added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels Jan 24, 2025
@mosabua
Copy link
Member

mosabua commented Jan 24, 2025

Should we also merge this in for 470?

@wendigo
Copy link
Contributor Author

wendigo commented Jan 24, 2025

No. I need more benchmarks on that one

This reverts commit 59ac727.

Jetty was updated to 12.0.16 which should solve HTTP/2 error handling.
@wendigo wendigo force-pushed the serafin/enable-http-2 branch from 6af16cf to 7c09cc0 Compare January 31, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Development

Successfully merging this pull request may close these issues.

3 participants