Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for authentication with Preview Web UI #24685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Jan 10, 2025

Description

Just a lift and shift and minor update of the content from the legacy UI .. this enables us to at some stage just remove that old page and UI. Please verify that what is written is actually true and let me know if we should remove or update anything.

Basically we should keep the docs for the preview UI separate and complete. In that realm also .. what do you think if we start adding some docs about each screen .. can be very high level

Additional context and related issues

#23230

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jan 10, 2025
@github-actions github-actions bot added the docs label Jan 10, 2025
@mosabua mosabua requested review from wendigo and koszti January 10, 2025 19:42
server and the Web UI. When the Trino server is configured to use a password
authenticator, the Web UI authentication type is automatically set to `FORM`. In
this case, the Web UI displays a login form that accepts a username and
password.
Copy link
Member

@koszti koszti Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might just be my experience, but I noticed that the FORM authentication type only accepts passwords when HTTPS is configured. This makes perfect sense from a security standpoint, but it took me a bit of research to understand why the password field was grayed out when only HTTP was configured. It could be helpful to clarify the difference between HTTP and HTTPS when using FORM auth for users to avoid confusion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct assessment. Passwords require https

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is covered in the earlier paragraph .. which I have now also reworded to be even more explicit .. if that is fine I can also do the same adjustment in the docs for the main UI.

The Preview Web UI requires users to authenticate. If Trino is not configured to
require authentication, then any username can be used, and no password is
required or allowed. The UI shows the login dialog for password authentication
with the password input deactivated. This is also automatically the case if the
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mosabua
Copy link
Member Author

mosabua commented Jan 14, 2025

Thoughts @wendigo @koszti ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants