-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support read 'p' type deletion vectors in Delta Lake #24946
Open
chenjian2664
wants to merge
1
commit into
trinodb:master
Choose a base branch
from
chenjian2664:delta_p_dv
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Feb 7, 2025
...lake/src/test/resources/deltalake/p_type_deletion_vectors/p_deletion_vector_source/README.md
Outdated
Show resolved
Hide resolved
...talake/p_type_deletion_vectors/p_deletion_vector_source/_delta_log/00000000000000000003.json
Outdated
Show resolved
Hide resolved
|
chenjian2664
force-pushed
the
delta_p_dv
branch
from
February 7, 2025 04:06
c5db214
to
5286b97
Compare
ebyhr
reviewed
Feb 7, 2025
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/delete/TestDeletionVectors.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
delta_p_dv
branch
2 times, most recently
from
February 7, 2025 06:44
7614584
to
e586019
Compare
ebyhr
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for comments.
...sts/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeCloneTableCompatibility.java
Outdated
Show resolved
Hide resolved
...sts/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeCloneTableCompatibility.java
Show resolved
Hide resolved
...sts/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeCloneTableCompatibility.java
Outdated
Show resolved
Hide resolved
...sts/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeCloneTableCompatibility.java
Show resolved
Hide resolved
chenjian2664
force-pushed
the
delta_p_dv
branch
3 times, most recently
from
February 7, 2025 09:32
d677a5b
to
e47c6bd
Compare
chenjian2664
force-pushed
the
delta_p_dv
branch
from
February 7, 2025 11:31
1056a0e
to
e887fbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is also a prerequirements for testing MERGE behavior with deletion vectors proposed in #24756
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: