Remove the Deprecated marker for S3StorageClassFilter

[zhaner08]

Description

hive.s3.storage-class-filter is still being used to filter out glacier objects when listing s3 objects. Remove the annotation to correct it

Additional context and related issues

Release notes

( X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

[pettyjamesm]

LGTM. @mosabua - seems like this got accidentally marked as deprecated as part of #24880, but this particular config shouldn't be removed.

[mosabua]

This should NOT be merged. All hive.s3 properties are deprecated .. if this is used in the new file system then it needs to be moved over and renamed .. we are planning to completely remove support for S3 via the legacy Hive-based classes.

fyi @electrum to chime in with more help if needed.

[pettyjamesm]

The issue is that this change is not implemented inside of the legacy S3 filesystem API (for reasons outlined in #21164) but rather directly in the Hive connector. So unlike the other S3 configs, this one in particular should persist beyond the deprecation. @electrum - feel free to weigh in if you disagree

[mosabua]

Hm .. I will let @electrum discuss the details on how to approach this more with you, but from my perspective we should at minimum change the property name. And if this is in a class or package that we will remove .. we probably want to move it as well.

[mosabua]

Maybe this is related and solves the issue - #24934

[wendigo]

We should add this to a native fs

[electrum]

I missed this when reviewing the deprecation PR. This is indeed a Hive connector property and unrelated to the S3 file system, aside from the unfortunately confusing naming. We could rename it if that will reduce confusion, but that might also just cause churn for no real benefit.

[mosabua]

Hmm.. but what about the linked PR then? #24934 .. isnt that the better solution / approach ..

[electrum]

This property is specifically about Glacier, which is a separate cold-storage system, while the linked PR is for other normal S3 storage classes. How about we follow up and rename this property to hive.s3-glacier-filter?

[mosabua]

This property is specifically about Glacier, which is a separate cold-storage system, while the linked PR is for other normal S3 storage classes. How about we follow up and rename this property to hive.s3-glacier-filter?

I think thats much better .. I hope it also limits usage of that property.. and we can get the other PR in as well for other use cases .. does that make sense to you as well @pettyjamesm and @zhaner08 ?

we should just use this PR to do the rename..

[electrum]

Put another way, this property controls whether Trino will attempt to read S3 objects that are in Glacier. The linked PR allows writing objects to normal S3 using a different storage class.

Stale