Cleanup previous snapshot files during materialized view refresh #25343
+136
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankvadariya
requested review from
findepi,
raunaqmorarka,
ebyhr and
alexjo2144
anusudarsan
reviewed
Mar 20, 2025
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMaterializedViewTest.java
Outdated
Show resolved
Hide resolved
SemionPar
reviewed
Mar 26, 2025
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Mar 26, 2025
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
mayankvadariya
force-pushed
the
mayank/materialized-view-old-files-cleanup
branch
from
94e6ce7 to
262a14b
Compare
ebyhr
reviewed
Mar 28, 2025
| fileSystem.deleteFiles(pathsToDelete); | ||
| } | ||
| catch (IOException e) { | ||
| throw new TrinoException(ICEBERG_FILESYSTEM_ERROR, "Failed to delete files during snapshot expiration", e); |
There was a problem hiding this comment.
The transaction is already committed at L3767. I'm wondering if we really need to throw an exception here.
There was a problem hiding this comment.
Good thought, we could change it to log.info or if we throw then, make the message little clear that the Trino couldn't collect the left over files from the refresh materialized view action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
REFRESH MATERIALIZED VIEWhttps://trino.io/docs/current/sql/refresh-materialized-view.html doesn't cleanup old snapshot files which causes materialized view size to grow without having any benefit of retaining old data.Proposed solution uses
org.apache.iceberg.ExpireSnapshotsprocedure inio.trino.plugin.iceberg.IcebergMetadata#finishRefreshMaterializedViewto cleanup previous snapshot created just before the execution of refresh materialized view command.Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: