Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eternal lock when hive metastore down during request with lock #25380

Conversation

anton-kutuzov
Copy link
Contributor

@anton-kutuzov anton-kutuzov commented Mar 21, 2025

Description

Added unlock for case when exception occur during get connection to metastore if we don't unlock this lock, it stills in database and next locks will wait it, this lock have never removed as request finished with exception.
Without fix the one way to unlock is remove raw manually in database

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Copy link

cla-bot bot commented Mar 21, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anton Kutuzov.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@github-actions github-actions bot added the hive Hive connector label Mar 21, 2025
@anton-kutuzov anton-kutuzov force-pushed the fix_lock_in_thrifthivemetasore_when_metastore_failed branch from d644e35 to 978443d Compare March 21, 2025 17:12
@cla-bot cla-bot bot added the cla-signed label Mar 21, 2025
@anton-kutuzov anton-kutuzov force-pushed the fix_lock_in_thrifthivemetasore_when_metastore_failed branch from 978443d to f3b52a2 Compare March 21, 2025 17:54
@anton-kutuzov anton-kutuzov force-pushed the fix_lock_in_thrifthivemetasore_when_metastore_failed branch from f3b52a2 to d68136c Compare March 21, 2025 17:54
@raunaqmorarka raunaqmorarka requested review from electrum and dain March 24, 2025 10:48
@electrum electrum merged commit 4f44b64 into trinodb:master Mar 29, 2025
57 checks passed
@electrum
Copy link
Member

Thanks!

@github-actions github-actions bot added this to the 475 milestone Mar 29, 2025
@anton-kutuzov anton-kutuzov deleted the fix_lock_in_thrifthivemetasore_when_metastore_failed branch March 29, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hive Hive connector
Development

Successfully merging this pull request may close these issues.

2 participants