Make golang build on Github

.github/workflows/build-golang.yml

@@ -17,18 +17,13 @@ on:
  - ".github/workflows/*golang*"
 
 jobs:
- test_go:
- name: Test
+ build-and-test-golang:
+ name: Build, Test
  runs-on: ${{ matrix.os }}
  strategy:
+ fail-fast: false
  matrix:
- include:
- - os: ubuntu-latest
- artifact_name: linux
- - os: windows-latest
- artifact_name: windows-gnu
- - os: macos-latest
- artifact_name: macos
+ os: [ ubuntu-latest, windows-latest] # , 'macos-latest' ] disabled due to macos issues
  steps:
  - uses: actions/checkout@v2
  - name: Download workflow artifact
@@ -41,16 +36,23 @@ jobs:
  uses: actions/setup-go@v2
  with:
  go-version: ^1.16
- - name: Display Golang version
+ - name: Set up Python
+ uses: actions/setup-python@v2
+ with:
+ python-version: 3.9
+ - name: Build and Test Golang
  run: |
  go version
  go install golang.org/x/lint/golint@latest
  go install github.com/jstemmer/go-junit-report@latest
- - name: Build, Test, Pack
- run: |
- ./devops/BuildGolang.ps1 -GitTag ${{ github.ref }} -TestOutput "test_output_${{ matrix.os }}.xml" -ArtifactName "${{ matrix.artifact_name }}"
+ python ../../devops/build_sdks.py
+ go build
+ golint
+ go test -v | go-junit-report > test_output.xml
  shell: pwsh
+ working-directory: go/services
  env:
+ API_GITHUB_TOKEN: ${{ secrets.API_GITHUB_TOKEN }}
  LD_LIBRARY_PATH: "${{ github.workspace }}/go/services"
  DYLD_FALLBACK_LIBRARY_PATH: "${{ github.workspace }}/go/services"
  DYLD_LIBRARY_PATH: "${{ github.workspace }}/go/services"
@@ -59,9 +61,26 @@ jobs:
  TEST_SERVER_ENDPOINT: staging-internal.trinsic.cloud
  TEST_SERVER_PORT: 443
  TEST_SERVER_USE_TLS: true
- - name: Publish Test Report
- uses: mikepenz/action-junit-report@v2
- if: always() # always run even if the previous step fails
+ - name: Upload Unit Test Results - Golang
+ if: always()
+ uses: actions/upload-artifact@v2
+ with:
+ name: Golang Unit Test Results (${{ matrix.os }})
+ path: 'go/services/test_output*.xml'
+
+ publish-test-results-golang:
+ name: Publish Test Results
+ needs: build-and-test-golang
+ runs-on: ubuntu-latest
+ if: always()
+
+ steps:
+ - name: Download Artifacts
+ uses: actions/download-artifact@v2
+ with:
+ path: golang_artifacts
+ - name: Publish Test Report - Golang
+ uses: EnricoMi/publish-unit-test-result-action@v1.23
  with:
- report_paths: ./go/services/test_output*.xml
- fail_on_failure: true
+ files: 'golang_artifacts/**/*.xml'
+ check_name: Golang Test Report

devops/build_sdks.py

@@ -91,7 +91,7 @@ def build_ruby(args) -> None:
 
 def build_golang(args) -> None:
  # Update version in setup.cfg
- golang_dir = abspath(join(dirname(__file__), '..', 'go', 'okapi'))
+ golang_dir = abspath(join(dirname(__file__), '..', 'go', 'services'))
  # Copy in the binaries
  copy_okapi_libs(golang_dir, 'windows-gnu')
 

go/services/loadcerts.go

@@ -0,0 +1,11 @@
+//go:build !windows
+// +build !windows
+
+package services
+
+import "crypto/x509"
+
+func loadWindowsCerts() []*x509.Certificate {
+ var certs []*x509.Certificate
+ return certs
+}

go/services/loadcerts_windows.go

@@ -0,0 +1,46 @@
+//go:build windows
+// +build windows
+
+package services
+
+import (
+ "crypto/x509"
+ "fmt"
+ "syscall"
+ "unsafe"
+)
+
+func loadWindowsCerts() []*x509.Certificate {
+ const CRYPT_E_NOT_FOUND = 0x80092004
+ // Copied from: https://github.com/golang/go/issues/16736#issuecomment-540373689
+ // Because golang team apparently doesn't believe that Windows deserves security.
+ storeHandle, err := syscall.CertOpenSystemStore(0, syscall.StringToUTF16Ptr("Root"))
+ if err != nil {
+ fmt.Println(syscall.GetLastError())
+ }
+
+ var certs []*x509.Certificate
+ var cert *syscall.CertContext
+ for {
+ cert, err = syscall.CertEnumCertificatesInStore(storeHandle, cert)
+ if err != nil {
+ if errno, ok := err.(syscall.Errno); ok {
+ if errno == CRYPT_E_NOT_FOUND {
+ break
+ }
+ }
+ fmt.Println(syscall.GetLastError())
+ }
+ if cert == nil {
+ break
+ }
+ // Copy the buf, since ParseCertificate does not create its own copy.
+ buf := (*[1 << 20]byte)(unsafe.Pointer(cert.EncodedCert))[:]
+ buf2 := make([]byte, cert.Length)
+ copy(buf2, buf)
+ if c, err := x509.ParseCertificate(buf2); err == nil {
+ certs = append(certs, c)
+ }
+ }
+ return certs
+}

go/services/services.go

@@ -8,17 +8,17 @@ import (
  "fmt"
  "github.com/trinsic-id/okapi/go/okapi"
  "github.com/trinsic-id/okapi/go/okapiproto"
- "google.golang.org/grpc/credentials"
- "net/url"
- "os"
- "strconv"
- "time"
-
  sdk "github.com/trinsic-id/sdk/go/proto"
  "google.golang.org/grpc"
+ "google.golang.org/grpc/credentials"
  "google.golang.org/grpc/metadata"
  "google.golang.org/protobuf/proto"
  _ "google.golang.org/protobuf/types/known/structpb"
+ "net/url"
+ "os"
+ "runtime"
+ "strconv"
+ "time"
 )
 
 type Document map[string]interface{}
@@ -138,12 +138,17 @@ func CreateChannel(serviceAddress string, blockOnOpen bool) (*grpc.ClientConn, e
  if serviceUrl.Scheme == "http" {
  dialOptions = append(dialOptions, grpc.WithInsecure())
  } else {
- // TODO - Get the credentials bundle
- pool, err := x509.SystemCertPool()
- if err != nil {
+ rootCAs, err := x509.SystemCertPool()
+ if err != nil && runtime.GOOS == "windows" {
+ rootCAs = x509.NewCertPool()
+ windowsCerts := loadWindowsCerts()
+ for _, cert := range windowsCerts {
+ rootCAs.AddCert(cert)
+ }
+ } else if err != nil {
  return nil, err
  }
- creds := credentials.NewClientTLSFromCert(pool, "")
+ creds := credentials.NewClientTLSFromCert(rootCAs, "")
  dialOptions = append(dialOptions, grpc.WithTransportCredentials(creds))
  }
  channel, err := grpc.Dial(dialUrl, dialOptions...)