Skip to content

Commit

Permalink
Build: Drop custom check for unused DB-unit test files (#12143)
Browse files Browse the repository at this point in the history
The custom check is nice, but.. it is custom. There is
a dependency on paths in the script that make it a bit
brittle. If we widen up the script to search all paths,
for db-test-files as well as the tests that use them,
then we run into performance problems.

All build checks need to have really, really high value
and good performance. Thus, instead of repaing this build
check, just dropping it instead.
  • Loading branch information
DanVanAtta authored Nov 28, 2023
1 parent ba6e80a commit 2f1f8b7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 51 deletions.
50 changes: 0 additions & 50 deletions .build/find-unused-dbunit-datasets

This file was deleted.

1 change: 0 additions & 1 deletion verify
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,4 @@ set -eu

checkDependency "docker" || installDocker
"$scriptDir/gradlew" spotlessApply check $@
"$scriptDir/.build/find-unused-dbunit-datasets"
"$scriptDir/.build/code-convention-checks/check-custom-style" spitfire-server

0 comments on commit 2f1f8b7

Please sign in to comment.