Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update triplea_maps.yaml #13092

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

RogerCooper
Copy link
Contributor

Adding Hellas

Notes to Reviewer

@beelee1 beelee1 merged commit 87f2634 into triplea-game:master Jan 2, 2025
1 check passed
@jtinbergen
Copy link

This commit breaks new installations as well as map downloading for everyone. The YAML parser does not like the ':' inside the title and falls over it. I thought this was the quickest way to reach out to you about it.

@RogerCooper
Copy link
Contributor Author

Going on vacation today. I will resubmit when I return.

@beelee1
Copy link
Contributor

beelee1 commented Jan 3, 2025

@RogerCooper ahh I see you are aware of the issue. Enjoy your vacation :)

beelee1 added a commit that referenced this pull request Jan 3, 2025
@beelee1
Copy link
Contributor

beelee1 commented Jan 3, 2025

@jtinbergen oh I misread your comment. Trying to revert it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants