Ai add land transports #3439
Merged
Ai add land transports #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ron-murhammer
commented
May 26, 2018
|
|
||
| // Set air units in any territory with no AA (don't move planes to empty territories) | ||
| for (final Iterator<Unit> it = sortedUnitAttackOptions.keySet().iterator(); it.hasNext();) { | ||
| final Unit unit = it.next(); | ||
| for (final Unit unit : sortedUnitAttackOptions.keySet()) { |
There was a problem hiding this comment.
Had to move away from iterator since there is potential to have to remove multiple units now.
ron-murhammer
commented
May 26, 2018
| @@ -95,27 +99,7 @@ public static int findMaxMovementForTransports(final List<ProPurchaseOption> sea | |||
| units.removeAll(unitsToIgnore); | |||
|
|
|||
| // Sort units by attack | |||
| units.sort((o1, o2) -> { | |||
There was a problem hiding this comment.
Moved to a separate method.
Codecov Report
@@ Coverage Diff @@
## master #3439 +/- ##
============================================
- Coverage 22% 21.99% -0.02%
- Complexity 5912 5914 +2
============================================
Files 832 832
Lines 71853 71912 +59
Branches 11575 11583 +8
============================================
+ Hits 15813 15816 +3
- Misses 53953 54011 +58
+ Partials 2087 2085 -2
Continue to review full report at Codecov.
|
|
Gonna look to merge this in the next day or so since its AI only changes. |
RoiEXLab
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AI support for moving units with land transports. Here is a 27 round test game on Iron War showing the AI moving them and not having any errors:
1527297106541-ironwarai.zip