-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When loading a game, restore dice stats from the history log. #3483
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3483 +/- ##
============================================
- Coverage 21.97% 21.97% -0.01%
+ Complexity 5919 5917 -2
============================================
Files 836 836
Lines 71983 71998 +15
Branches 11590 11593 +3
============================================
- Hits 15820 15819 -1
- Misses 54075 54089 +14
- Partials 2088 2090 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small comment.
As always: Screenshots are appreciated
PlayerID playerId = gameData.getPlayerList().getPlayerId(playerName); | ||
|
||
DiceRoll diceRoll = (DiceRoll) childNode.getRenderingData(); | ||
int[] rolls = new int[diceRoll.size()]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned earlier, we have this weird style guideline to make everything final that's not being changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes #3478.