Add ability for notifications to only go to accepters. #3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for fixing #3558 with a corresponding chsange to the Feudal Japan map setting the new property.
Codecov Report
@@ Coverage Diff @@
## master #3560 +/- ##
============================================
- Coverage 21.98% 21.97% -0.01%
Complexity 5919 5919
============================================
Files 838 838
Lines 71989 71995 +6
Branches 11550 11550
============================================
Hits 15824 15824
- Misses 54075 54081 +6
Partials 2090 2090
Continue to review full report at Codecov.
|
|
@asvitkine If I understand right only two players would see notifications. If so, would other players maybe miss the notifications, or are the notifications not useful and pretty much just noise? |
|
@asvitkine Closing. See my comments in #3558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for fixing #3558
with a corresponding change to the Feudal Japan map setting the new property.