Handle trigger attachments that still use deprecated isSuicide #6970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
DanVanAtta
reviewed
Jul 1, 2020
| try { | ||
| isValueTheSame = newValue.equals(propertyAttachment.getRawPropertyString(propertyName)); | ||
| } catch (final UnsupportedOperationException e) { | ||
| throw new UnsupportedOperationException( |
There was a problem hiding this comment.
The extra debug information here is excellent - much better error handling 👍
DanVanAtta
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
getIsSuicideback so that the trigger attachments in TWW will still work.I've also wrapped the exception inside a new exception that has the name of the trigger, the property, and what type of attachment it is on. This should help in finding and fixing similar issues.
Fixes #6961
Functional Changes
[] New map or map update
[] New Feature
[] Feature update or enhancement
[] Feature Removal
[] Code Cleanup or refactor
[] Configuration Change
[x] Problem fix
[] Other:
Testing
Loaded a TWW save that triggered it, verified that the unit attachment had suicide turned off before non-combat and then had it turned back on after non-combat. And then I let the UI play for several more rounds to see if anything else might happen.
Screens Shots
Additional Notes to Reviewer
Release Note
FIX|TWW will no longer crash before Germany's non-combat phase.