Return the screen size in logical pixels, not screen pixels. #7030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, if the user has magnification turned on in Windows, the returned size is correspondingly scaled down. This is the behavior that we want, as we use this size to compare against Swing UI sizes, which is in logical pixels (gets scaled by the system setting).
RoiEXLab
approved these changes
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the screen size in logical pixels, not screen pixels.
This way, if the user has magnification turned on in Windows, the returned size is correspondingly scaled down. This is the
behavior that we want, as we use this size to compare against Swing UI sizes, which is in logical pixels (gets scaled by the system setting).
Functional Changes
[] New map or map update
[] New Feature
[] Feature update or enhancement
[] Feature Removal
[] Code Cleanup or refactor
[] Configuration Change
[X] Problem fix: #6825
[] Other:
Testing
Tested on Windows 10 by changing the magnification setting and verifying the new method returns the scaled size (different from the previous implementation which was the unscaled size).
Release Note
Fixes combat window sizing with Windows 10 magnification