Simplify last map update check parsing and set threshold for last check to 7 days #7243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck to 7 days 1. Simplify: Rather than storing a formatted string for the last time we checked for map updates, just store the equivalent epoch milli timestamp. 2. Adjust threshold for checking for maps to be every 7 days rather than once a month. The once a month made more sense when the map list was hosted on source forge and the download time was very slow, with a fast download of the map list we can check more often and thereby get better responsiveness to map version updates. Fixes last map-date-check parsing error reported in: #7014
DanVanAtta
force-pushed
the
simplify-update-map-checks-last-date-parsing
branch
from
aedfea2 to
1e172d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #7243 +/- ##
============================================
- Coverage 23.83% 23.82% -0.02%
+ Complexity 6971 6966 -5
============================================
Files 1160 1161 +1
Lines 78785 78788 +3
Branches 11368 11367 -1
============================================
- Hits 18777 18769 -8
- Misses 57827 57838 +11
Partials 2181 2181
Continue to review full report at Codecov.
|
|
Code Climate has analyzed commit 1e172d5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 26.6% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify: Rather than storing a formatted string for the last time we checked for
map updates, just store the equivalent epoch milli timestamp.
Adjust threshold for checking for maps to be every 7 days rather than once
a month. The once a month made more sense when the map list was hosted on source
forge and the download time was very slow, with a fast download of the map
list we can check more often and thereby get better responsiveness to map
version updates.
Fixes last map-date-check parsing error reported in:
#7014
Functional Changes
[] New map or map update
[] New Feature
[] Feature update or enhancement
[] Feature Removal
[] Code Cleanup or refactor
[x] Configuration Change
[x] Problem fix
[] Other:
Testing
Screens Shots
Additional Notes to Reviewer
Release Note
FIX|Rare date parser error on game launch when checking for out-of-date maps