Fix: Restore leniency for mismatching territory names #7419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for new territory naming to be ignored in favor of "old" territory. This allows territory naming to line up with polygons.txt and centers.txt, without the matching is strict and territory names can appear as 'none' which disallows movements into those territories. Partial revert of: #7233 Fixes: #7386
Codecov Report
@@ Coverage Diff @@
## master #7419 +/- ##
=========================================
Coverage 23.93% 23.93%
- Complexity 6948 6949 +1
=========================================
Files 1165 1165
Lines 78714 78705 -9
Branches 11354 11356 +2
=========================================
+ Hits 18838 18839 +1
+ Misses 57692 57683 -9
+ Partials 2184 2183 -1
Continue to review full report at Codecov.
|
|
Code Climate has analyzed commit d4efbce and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 26.7% (0.0% change). View more on Code Climate. |
DanVanAtta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for new territory naming to be ignored in favor of "old"
territory. This allows territory naming to line up with polygons.txt
and centers.txt, without the matching is strict and territory names
can appear as 'none' which disallows movements into those territories.
Partial revert of: #7233
Fixes: #7386
Testing
Double check WaW 1940 map movement into renamed territories.
Screens Shots
Additional Notes to Reviewer
Release Note
FIX|Movement incorrectly disallowed into certain territories on WaW