Remove unused color property type from DTD and impossible file property type #7528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty type 1) No map uses the 'color' property type, eg: <property name="colorProperty> <color/> </property> 2) In the property type handling code there is an option for a "file" type. That is not defined in the DTD as a valid tag to property and hence would be impossible to have.
|
Code Climate has analyzed commit ec6dfd0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 26.8% (0.0% change). View more on Code Climate. |
RoiEXLab
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<property name="colorProperty>
a "file" type. That is not defined in the DTD as a valid
tag to property and hence would be impossible to have.
Testing
In a folder where I have all maps checked out, ran:
Screens Shots
Additional Notes to Reviewer
Release Note
REMOVE|Remove XML 'color' property option