Fix: Use all of the friendly units for support calculation in OOL #8000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the targetsToPickFrom is a subgroup of all of the units on the other side, then the support calculation will be incorrect. This could cause the OOL to be calculated incorrectly. An example would be submarines fighting air planes and other surface ships. The submarines can't hit the air planes so the targetsToPickFrom is just the surface ships. But the air planes might give support to the surface ships and make some ships more valuable than normal.
Codecov Report
@@ Coverage Diff @@
## master #8000 +/- ##
=========================================
Coverage 24.84% 24.84%
+ Complexity 7288 7287 -1
=========================================
Files 1251 1251
Lines 79102 79104 +2
Branches 11162 11162
=========================================
+ Hits 19653 19655 +2
+ Misses 57356 57355 -1
- Partials 2093 2094 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the targetsToPickFrom is a subgroup of all of the units on the other
side, then the support calculation will be incorrect. This could cause
the OOL to be calculated incorrectly.
An example would be submarines fighting air planes and other surface
ships. The submarines can't hit the air planes so the targetsToPickFrom
is just the surface ships. But the air planes might give support to the
surface ships and make some ships more valuable than normal.
Testing
Screens Shots
Additional Notes to Reviewer
Release Note
FIX|Default Order of Loss will now take into account support from all units in the battle, not just from the units that are currently being targeted. For example, in a battle where a submarine is fighting air units and other surface ships, the default order of loss was ignoring any support the air units could give to the surface ship.