Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential NPE when clicking 'ctrl+A' to add units to battle calc #8276

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

DanVanAtta
Copy link
Member

Clicking around on map with 'ctrl+A' can encounter a NPE due
to null 'current territory'

Testing

Screens Shots

Additional Notes to Reviewer

Release Note

FIX|Fix potential NullPointerException message when pressing 'ctrl+a' to add units to battle calculator

Clicking around on map with 'ctrl+A' can encounter a NPE due
to null 'current territory'
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #8276 (fda2bf4) into master (a7a7576) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8276   +/-   ##
=========================================
  Coverage     24.83%   24.84%           
+ Complexity     7304     7303    -1     
=========================================
  Files          1265     1265           
  Lines         79592    79565   -27     
  Branches      11085    11075   -10     
=========================================
- Hits          19765    19764    -1     
+ Misses        57754    57727   -27     
- Partials       2073     2074    +1     
Impacted Files Coverage Δ Complexity Δ
...ategy/triplea/ai/pro/data/ProTerritoryManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...riplea/odds/calculator/BattleCalculatorDialog.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...egy/triplea/ui/PlacementUnitsCollapsiblePanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...trategy/triplea/ui/unit/scroller/UnitScroller.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/games/strategy/triplea/delegate/Matches.java 45.03% <0.00%> (-0.11%) 374.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0979f7...fda2bf4. Read the comment docs.

@DanVanAtta DanVanAtta merged commit ee7679f into master Nov 26, 2020
@DanVanAtta DanVanAtta deleted the fix-npe-in-battle-calc-add-units branch November 26, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant