Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the player name in the step definition is valid #8384

Conversation

trevan
Copy link
Contributor

@trevan trevan commented Dec 8, 2020

Fixes #8214

Testing

I started a game using the map from #8214 and verified the error was shown correctly.
I started a game from a few other maps and verified that an error didn't occur.

Screens Shots

Additional Notes to Reviewer

It is possible that other released maps might show this error. I didn't check every map. But when those errors come in, they should be easily fixed.

Release Note

CHANGE|Invalid player names in a step definition will now cause an error to be shown when the map is first loaded.

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #8384 (a0f89a8) into master (a7a7576) will increase coverage by 0.04%.
The diff coverage is 50.70%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8384      +/-   ##
============================================
+ Coverage     24.83%   24.87%   +0.04%     
- Complexity     7304     7341      +37     
============================================
  Files          1265     1274       +9     
  Lines         79592    79520      -72     
  Branches      11085    11034      -51     
============================================
+ Hits          19765    19779      +14     
+ Misses        57754    57682      -72     
+ Partials       2073     2059      -14     
Impacted Files Coverage Δ Complexity Δ
.../strategy/engine/data/BombingUnitDamageChange.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/games/strategy/engine/data/UnitHitsChange.java 0.00% <ø> (-70.00%) 0.00 <0.00> (-6.00)
...a/changefactory/units/BombingUnitDamageChange.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...es/strategy/engine/data/gameparser/GameParser.java 81.28% <0.00%> (-0.59%) 142.00 <0.00> (+1.00) ⬇️
...trategy/engine/delegate/DefaultDelegateBridge.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../games/strategy/engine/framework/AbstractGame.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/games/strategy/engine/framework/ClientGame.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/games/strategy/engine/framework/GameRunner.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/games/strategy/engine/framework/ServerGame.java 0.57% <0.00%> (-0.01%) 1.00 <0.00> (ø)
.../system/loader/AvailableGamesFileSystemReader.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37a902b...a0f89a8. Read the comment docs.

@DanVanAtta DanVanAtta merged commit 2485dec into triplea-game:master Dec 9, 2020
DanVanAtta added a commit that referenced this pull request Dec 9, 2020
DanVanAtta added a commit that referenced this pull request Dec 9, 2020
DanVanAtta added a commit that referenced this pull request Dec 9, 2020
@trevan trevan deleted the prevent-null-players-in-steps-if-a-player-name-is-requested branch December 9, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numetalfan ojectives.properties 2.5 Release Problem
2 participants