Skip to content

Run unit tests on master for code coverage reports #8594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Conversation

RoiEXLab
Copy link
Member

@RoiEXLab RoiEXLab commented Jan 6, 2021

This is a partial revert of #8257
The codecov coverage is completely messed up because there no longer are reports from master, so the diff says nothing really making it useless.
This change restores the "old" behaviour for unit tests so that the reports make sense now.

EDIT: actually we only need builds when pushing to master, so I added that in

@RoiEXLab
Copy link
Member Author

RoiEXLab commented Jan 6, 2021

/cc @DanVanAtta

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #8594 (df858a3) into master (a7a7576) will increase coverage by 0.06%.
The diff coverage is 23.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8594      +/-   ##
============================================
+ Coverage     24.83%   24.90%   +0.06%     
- Complexity     7304     7371      +67     
============================================
  Files          1265     1288      +23     
  Lines         79592    80308     +716     
  Branches      11085    11013      -72     
============================================
+ Hits          19765    19999     +234     
- Misses        57754    58240     +486     
+ Partials       2073     2069       -4     
Impacted Files Coverage Δ Complexity Δ
...ava/org/triplea/ai/does/nothing/DoesNothingAi.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...triplea/ai/does/nothing/DoesNothingAiProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../main/java/org/triplea/ai/flowfield/Constants.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ain/java/org/triplea/ai/flowfield/FlowFieldAi.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../org/triplea/ai/flowfield/FlowFieldAiProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ea/ai/flowfield/influence/InfluenceMapBuilder.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../triplea/ai/flowfield/influence/ResourceValue.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/ai/flowfield/influence/TerritoryDebugAction.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...field/influence/defense/AllyResourceToProtect.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...owfield/influence/defense/MyResourceToProtect.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 460 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315460c...df858a3. Read the comment docs.

@RoiEXLab RoiEXLab merged commit 5d6c93a into master Jan 6, 2021
@RoiEXLab RoiEXLab deleted the RoiEXLab-patch-1 branch January 6, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant