Remove game notes action tab

[DanVanAtta]

Several discussions have happened in forums, generall agreed that the
game notes in the action tabs is not particularly useful. To keep things
simpler, this update remove the game notes tab.

Release Notes

REMOVE|Removed game notes 'action' tab, game notes are now only available from the 'help > game notes' menu.

[beelee1]

I agree but just want to point out that you can't move the map when accessing the game notes from the help tab. It'd be nice if you could. Not a biggy but still a difference.

[codecov]

Codecov Report

Merging #8925 (ab6e0c6) into master (1b1f976) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #8925   +/-   ##
=========================================
  Coverage     28.40%   28.40%           
- Complexity     8365     8366    +1     
=========================================
  Files          1300     1299    -1     
  Lines         80823    80817    -6     
  Branches      11039    11039           
=========================================
- Hits          22956    22955    -1     
+ Misses        55696    55693    -3     
+ Partials       2171     2169    -2     

Impacted Files	Coverage Δ	Complexity Δ
...n/java/games/strategy/triplea/ui/TripleAFrame.java	0.00% <ø> (ø)	0.00 <0.00> (ø)
...trategy/triplea/ui/menubar/help/GameNotesMenu.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...rc/main/java/games/strategy/net/nio/NioReader.java	82.50% <0.00%> (-3.75%)	17.00% <0.00%> (-1.00%)
.../src/main/java/games/strategy/net/nio/Decoder.java	75.86% <0.00%> (ø)	14.00% <0.00%> (ø%)
...strategy/net/nio/ServerQuarantineConversation.java	91.22% <0.00%> (+1.75%)	13.00% <0.00%> (+1.00%)
...lea/ai/flowfield/influence/InfluenceTerritory.java	100.00% <0.00%> (+3.03%)	14.00% <0.00%> (+1.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b1f976...6bfc16d. Read the comment docs.

[Cernelius]

I'm against this change unless it is also assured that the notes always stay above the map view. I'm referring to the following issue, which impacts the game notes as well as the unit help window.
#8607

Even in case that would be fixed, it has so far happened so frequently that windows have issues of various kind that I would suggest keeping this rather useless tab just as a fall-back for future issues with windows.

Besides, I think this is something which should be better discussed in forum (just ask users if they like reading notes in the tabs any better than via the menu).

[beelee1]

@Cernelius I think it was talked about in forum. i had meant to comment but forgot about it until seeing it here.

edit
Yea #8607 makes a good point. i wasn't aware of that

[DanVanAtta]

@Cernelius I think it was talked about in forum. i had meant to comment but forgot about it until seeing it here.

Yes, it was. I'm not sure where the thread is, the consensus between several folks was that it's not useful.

[DanVanAtta]

Fixing the always on top seems easy enough actually, will follow up.