Set game notes & unit help windows to always be on top

[DanVanAtta]

Testing

Screens Shots

Additional Notes to Reviewer

Release Note

UPDATE|Game notes and unit help windows are now always displayed on top of other windows

[codecov]

Codecov Report

Merging #8926 (3e25662) into master (51b2a42) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #8926      +/-   ##
============================================
- Coverage     28.40%   28.39%   -0.01%     
+ Complexity     8364     8362       -2     
============================================
  Files          1299     1299              
  Lines         80817    80818       +1     
  Branches      11039    11039              
============================================
- Hits          22954    22952       -2     
- Misses        55693    55695       +2     
- Partials       2170     2171       +1     

Impacted Files	Coverage Δ	Complexity Δ
...egy/triplea/ui/menubar/help/InformationDialog.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...rc/main/java/games/strategy/net/nio/NioReader.java	82.50% <0.00%> (-3.75%)	17.00% <0.00%> (-1.00%)
...lea/ai/flowfield/influence/InfluenceTerritory.java	96.96% <0.00%> (-3.04%)	13.00% <0.00%> (-1.00%)
.../main/java/games/strategy/net/ClientMessenger.java	62.50% <0.00%> (-2.09%)	17.00% <0.00%> (-1.00%)
...ine/message/unifiedmessenger/UnifiedMessenger.java	72.04% <0.00%> (+1.24%)	27.00% <0.00%> (+1.00%)
...rc/main/java/games/strategy/net/nio/NioWriter.java	81.25% <0.00%> (+2.08%)	20.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b2a42...3e25662. Read the comment docs.

[Cernelius]

This should apply to anything like this all the same (the unit help tab and whatever information window like that).

---

This (game notes always on top) was the behaviour in the past, but it caused the notes to hide prompts (for example, when you were reading the notes and suddenly you received a prompt for whatever reason), so the behaviour was changed to the current. In practice, the games notes should always be above the map view but below everything else (so, if you get a politics prompt or a battle window, that appears above the game notes while the game notes stay below every prompt but above the map).

Rather than being always on top, the game notes should be set being never behind the map view or, even better, the map view itself should be set being always below everything else.

[DanVanAtta]

Rather than being always on top, the game notes should be set being never behind the map view or, even better, the map view itself should be set being always below everything else.

That is not possible unfortunately.

This (game notes always on top) was the behaviour in the past, but it caused the notes to hide prompts (for example, when you were reading the notes and suddenly you received a prompt for whatever reason), so the behaviour was changed to the current.

[DanVanAtta]

This (game notes always on top) was the behaviour in the past, but it caused the notes to hide prompts (for example, when you were reading the notes and suddenly you received a prompt for whatever reason), so the behaviour was changed to the current.

Fun stuff : )

This is a good point to bring up. I think the picture might have changed after we set various other dialogs to not be frames and toggled modality. I checked that a modal dialog appearing is not hidden, the prompt does appear above the notes window. Specifically I checked a politics notification. With luck this UX will be universal on all OS's.

[Cernelius]

This (game notes always on top) was the behaviour in the past, but it caused the notes to hide prompts (for example, when you were reading the notes and suddenly you received a prompt for whatever reason), so the behaviour was changed to the current.

Fun stuff : )

This is a good point to bring up. I think the picture might have changed after we set various other dialogs to not be frames and toggled modality. I checked that a modal dialog appearing is not hidden, the prompt does appear above the notes window. Specifically I checked a politics notification. With luck this UX will be universal on all OS's.

I think this migh be the case, because there are a lot of other information windows which already have the always on top behaviour and I don't recall, for example, any report of someone getting stuck while reading the "Politics Panel".

On this matter, as I said

This should apply to anything like this all the same

I also think the "Map Options" (this shows the game options, you may have selected before loading the game), the "Politics Panel", the "Random Stats", the "Game Statistics" and the "Movement/Selection Help" should have the same behaviour as the "Unit Help" and the "Game Notes". I'm not seeing why any information window should behave any differently from any other one (I would make exception only for the "TripleA Console", as it is not really a user information widow.).

Off topic, but maybe all windows that are only for giving information should be consolidated within one menu category. Like changing "Help" to "Information" and putting them all there.

[DanVanAtta]

I'll have to think about if we want all windows to be always on top. I'd like more feedback on it from others as well. In the meantime this update will fix the problem reported. I do see a use-case where you want the unit help or game-notes to be visible while moving around on the map.