Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TL-34944: Add logic to pass networkId back in the bid response #69

Merged
merged 22 commits into from
Feb 15, 2023

Conversation

patrickloughrey
Copy link

@patrickloughrey patrickloughrey commented Feb 13, 2023

Type of change

  • Feature

Description of change

  • Added support to parse the memberId portion of crid and set it as meta.networkId if TLX sends crid back in the supplier bid response
  • Thoroughly tested this functionality using sample bid response object found on Prebid.org
  • Added unit test to account for this scenario

Copy link

@nllerandi3lift nllerandi3lift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's pop in front of Connections. Just want to keep them apprised of any changes we make.
Let's include reference to the docs when making mention of meta.networkId
https://docs.prebid.org/dev-docs/bidder-adaptor.html#interpreting-the-response

@nllerandi3lift
Copy link

We can PR this into main prebid when youre ready @patrickloughrey

@patrickloughrey patrickloughrey merged commit 6b55848 into master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants