Add triplelift adapter #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colbertk
reviewed
Jan 6, 2020
| var EventsService; | ||
| var RenderService; | ||
|
|
||
| //? if (DEBUG) { |
There was a problem hiding this comment.
I think these are macros provided in the IX adapter template, possibly for the debugger UI? They're in all the adapters in the library.
willchapin
approved these changes
Jan 7, 2020
| @@ -0,0 +1,9 @@ | |||
| //? if(FEATURES.GPT_LINE_ITEMS) { | |||
There was a problem hiding this comment.
I'm assuming the ix system uses all these?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmaxparam to auction request (d803d45). There doesn't seem to be a way yet to test theconfigs.timeoutargument via IX's system tester.5e4efe9).4076aa4). Again, there is no way yet to confirm this behavior via the system tester, so IX is having these updates merged to their canary branch for live testing (example here).