Add support for custom fields + generation parameters #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, @mdehoog, thanks for your work, I'll review the code as soon as possible. |
|
@vmx hi, could you help to review the code? |
vmx
reviewed
Feb 28, 2024
Thanks. |
|
@mdehoog plz check the github workflow. Thanks. |
mdehoog
force-pushed
the
gnark-crypto-elements
branch
from
71ec48a to
117dc8b
Compare
|
@triplewz thanks for the review! Removed the tests from the workflow 👍 |
mdehoog
added a commit
to mdehoog/poseidon
that referenced
this pull request
Mar 1, 2024
(now that triplewz/poseidon#2 is merged)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly thank you for your poseidon implementation, I've found it very helpful personally.
This PR adds support for passing in custom field elements from the gnark-crypto library as a generic argument. This means any curve can be used, not just BLS12-381.
Secondly, it adds the ability to pass in custom values for
rp,rf,field,sbox, and themdsmatrix to the constant generation function. I've been able to reproduce the circom's constants exactly when usingfield=1,sbox=0, andrp/rf/mdsvalues calculated by https://extgit.iaik.tugraz.at/krypto/hadeshash/-/blob/master/code/generate_params_poseidon.sage (with a minor modification to round uprpto the nearest multiple ofwidth).Totally understandable if this major refactor is outside the scope of this repo, I'd be happy to maintain a fork if preferred.