Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong result with broadcasted function #10

Closed
aminya opened this issue Apr 16, 2020 · 2 comments
Closed

Wrong result with broadcasted function #10

aminya opened this issue Apr 16, 2020 · 2 comments

Comments

@aminya
Copy link

aminya commented Apr 16, 2020 •
edited
Loading 

using GFlops

x = rand(10)

@gflops sin.($x)

gives 0.0

blocking aminya/AcuteBenchmark.jl#2 and JuliaSIMD/LoopVectorization.jl#5
@ffevotte
Copy link
Member

Can you confirm that this happens only with Julia 1.4?

If so, it looks suspiciously like issue #6, which is due to some incompatibilities between (the currently released version of) Cassette.jl and Julia v1.4.

In local tests, I can indeed confirm that Cassette's current master fixes this issue too, most probably thanks to this PR.

@ffevotte ffevotte mentioned this issue Apr 17, 2020
Closed
@aminya
Copy link
Author

aminya commented Apr 20, 2020

I only tried in Julia 1.4. I don't have an older version to try.

ffevotte added a commit that referenced this issue Apr 20, 2020
@ffevotte
More tests
41c5fa3 
Add in particular a test about broadcasting in order to help detect issues such
as gh-10.
@ffevotte ffevotte mentioned this issue Apr 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ffevotte @aminya