Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GFlops should use minimum time instead of mean #15

Closed
ffevotte opened this issue Dec 20, 2020 · 0 comments · Fixed by #16
Closed

GFlops should use minimum time instead of mean #15

ffevotte opened this issue Dec 20, 2020 · 0 comments · Fixed by #16

Comments

@ffevotte
Copy link
Member

GFlops should be estimated based on the minimum time measurement reported by BenchmarkTools, instead of taking the mean time. This would be more consistent with current best practices, as they are implemented in @btime itself.
ffevotte added a commit that referenced this issue Dec 20, 2020
@ffevotte
Fix @gflops issues
28e0419 
- Display memory allocs (Closes: #5)

- Estimate GFlops based on the minimum time measurement provided by
  `@btime` (Closes: #15)
@ffevotte ffevotte mentioned this issue Dec 20, 2020
Merged
@ffevotte ffevotte mentioned this issue Dec 23, 2020
Merged
ffevotte referenced this issue Dec 23, 2020
@ffevotte
Prepare for release 0.1.3
9c28058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix @gflops issues triscale-innov/GFlops.jl
1 participant
@ffevotte