-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding unary ops (inv, sqrt) #3
Comments
Thanks for your comment! I made the required changes to handle unary ops, in particular sqrt:
I'm not sure what you meant about
If you have ideas for other FP intrinsics which should be counted, please do not hesitate to either add them or tell me. I was thinking of maybe adding comparison operators, FMA and rounding operators, but apart from that I'm short on ideas... |
fma and muladd are key. both are 3arg functions (so are hypot, clamp). There are natural sets of them -- I'll put together a look at that. ---- perhaps only instrumenting the ops desired would be more performant |
FMA ops are now counted thanks to #12. This also provides an example how to add 3-argument functions. I do agree that there isn't much difficulty in tracking more instruction types, but showing the information is going to be less and less readable as the number of tracked ops increases. Not sure how to improve on this part though... any idea will be much appreciated! |
Happy to hear this update. ⛵
If all the nonzero entries are for 64bit [32bit] ops, only one column should be shown. |
Good idea, thanks! Filtering empty rows/columns should be relatively easy. Formatting everything in a nicely aligned table should be straightforward too; perhaps even more so if we can leverage the features of |
This is a PrettyTables-based implementation of a format similar to what's suggested in #3
This is a PrettyTables-based implementation of a format similar to what's suggested in #3
The I think this is worth the extra dependency. |
I use them quite a bit within arithmetic expressions. If you add them (so I have something to copy), and you want them -- I would PR other widely used unary math functions.
The text was updated successfully, but these errors were encountered: