Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen compat bounds, bump version #41

Closed

Conversation

charleskawczynski
Copy link
Contributor

@charleskawczynski charleskawczynski commented Sep 20, 2022

Hello, and thanks for the great package! This PR widens the compat bounds so that users can upgrade to newer versions.

This passes all the tests for me with julia 1.7 and 1.8

@tristanmontoya
Copy link

The conflict with PrettyTables is preventing me from using the latest version of PrettyTables in my package StableSpectralElements.jl. Would someone (@ffevotte?) be willing to review and merge this PR? Thanks so much!

@ffevotte
Copy link
Member

Yes, I'm very sorry about not taking proper care of the package in the past few months. Unfortunately it looks like some things have broken for Julia 1.9+
Let me check what happens a bit more thoroughly; hopefully I'll have something working soon. Please feel free to ping me if you don't see anything coming by the end of August.

@ffevotte
Copy link
Member

ffevotte commented Aug 27, 2023

Thanks a lot @charleskawczynski for this PR! I took the liberty of rebasing it in #46, in which I also introduced a few changes:

  • I think it is incorrect to widen the compat bounds for Cassette; as far as I recall, versions 0.3.0 & 0.3.1 really aren't compatible with GFlops
  • I simplified a bit the code handling PrettyTables: I don't think it is necessary to be able to support versions 1 & 2 simultaneously, so GFlops.jl v0.1.7 only declares compatibility with PrettyTables v2.

@tristanmontoya does this work for you?

In any case, I'm going to close this PR, considering that it is superseded by #46, but if any of you feel like I missed something, please do not hesitate to re-open it.

Thanks again!

@ffevotte ffevotte closed this Aug 27, 2023
ffevotte referenced this pull request Aug 27, 2023
@tristanmontoya
Copy link

tristanmontoya commented Aug 27, 2023

@ffevotte thanks so much - it works for me!

@charleskawczynski
Copy link
Contributor Author

Hi @ffevotte, sounds good to me, and thanks for getting that merged! Are you planning to eventually update Cassette?

@ffevotte
Copy link
Member

Hi @charleskawczynski

Do you have a specific Cassette version in mind? Currently, it looks like installing GFlops in a fresh environment results in bringing Cassette v0.3.12 as a dependency. Which I think is the latest released version... Or did I miss something?

@charleskawczynski
Copy link
Contributor Author

Ah, yes, the latest one. I just realized the previous compat should be fine for updating. All is well, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants