Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added syntest example to run ST syntax tests #44

Merged
merged 10 commits into from
Mar 17, 2017
Merged

added syntest example to run ST syntax tests #44

merged 10 commits into from
Mar 17, 2017

Commits on Mar 16, 2017

  1. added syntest example to run ST syntax tests

    @keith-hall @trishume
    keith-hall authored and trishume committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    8a957ff View commit details
    Browse the repository at this point in the history

  2. fix bug in ScopeRegionIterator skipping the last operation on the line

    @keith-hall @trishume
    keith-hall authored and trishume committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    29a24e5 View commit details
    Browse the repository at this point in the history

  3. don't ignore assertions after the newline, assert them against newline

    @keith-hall @trishume
    keith-hall authored and trishume committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    5eac892 View commit details
    Browse the repository at this point in the history

  4. store original path when syntax is loaded, and use that in syntest 

    commit ammended later to remove changes to packdump files, to reduce
repo size.
    @keith-hall @trishume
    keith-hall authored and trishume committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    1904dc2 View commit details
    Browse the repository at this point in the history

  5. support exclude-only scope selectors that don't start with a space

    @keith-hall @trishume
    keith-hall authored and trishume committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    09b64b4 View commit details
    Browse the repository at this point in the history

  6. Refactor the data structure used to find syntaxes by file. 

    This change makes it so that it can't crash on non-UTF8 paths,
makes lookup by file path more efficient, and avoids allocating
a hash map data structure that is never used as a map.

It also adds a test of the functionality

Signed-off-by: Tristan Hume <tris.hume@gmail.com>
    @trishume
    trishume committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    7b5e125 View commit details
    Browse the repository at this point in the history

  7. make test behaviour more like ST's when not only tests are on the line 

    i.e. the ASP syntax tests make use of this behavior, to test whether line continuation punctuation works properly
    @keith-hall @trishume
    keith-hall authored and trishume committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    a4030a4 View commit details
    Browse the repository at this point in the history

  8. Clean and comment ScopeRegionIterator 

    I did this to make it clearer what was going on, so that I could understand it
again and review that it was doing the right thing, since I clearly got it
wrong the first time.
    @trishume
    trishume committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    ac8b32b View commit details
    Browse the repository at this point in the history

  9. Clean up syntest.rs example 

    The error handling in test_file was rearranged to use
the try! macro and ok_or combinator. This decreases
indentation and makes the code easier to read.

It is recommended to view this diff without whitespace
to make it clearer what actually changed.
    @trishume
    trishume committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    ee5482f View commit details
    Browse the repository at this point in the history

  10. trim scope selector at test token end 

    i.e. allow text after the assertion to not interfere with the assertion. This is how ST works when it executes the syntax tests.
    @keith-hall @trishume
    keith-hall authored and trishume committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    045dd0c View commit details
    Browse the repository at this point in the history