Fix navigation bar and extension view hiding suddenly #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristanhimmelman
added a commit
that referenced
this pull request
Jan 19, 2016
Fix navigation bar and extension view hiding suddenly
|
Thanks @felipowsky ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right after a small pan gesture that wasn't enough to hide the navigation bar and the extension view, if pan gesture is fired again the navigation and the extension hide suddenly.
I noticed this bug happening more frequently with an extension view but I think it's possible to simulate it in other scenarios.
Here an example:
Fixed it by resetting the
previousYOffsetathandleScrollingEndedtoNaN.Here's the expected result:
