Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport does not guarantee arbiter properties to be transported #9

Open
tristanls opened this issue Feb 28, 2014 · 1 comment
Open
Labels

Comments

@tristanls
Copy link
Owner

Currently, the transport interface guarantees that contact.id and contact.data will be transported. Additionally, the transport interface reserves contact.transport property for internal use.

The behavior, when transported, of properties used by the example arbiters, such as contact.vectorClock or contact.workerNodes is undefined.

It would not do to simply add these properties into contact.data, because the user might not give a crap that vector clocks or other magic are being used.

One approach would be to require the transport interface to guarantee that contact.arbiter property is transported and standardize around the arbiters using that much in the same way that transports standardize around using contact.transport. This approach allows the user to only care about contact.id and contact.data, while not preventing arbiters to rewrite contact.data based on information in contact.arbiter.

@tristanls tristanls added the bug label Mar 2, 2014
tristanls added a commit that referenced this issue Mar 2, 2014
@tristanls
Copy link
Owner Author

This is a protocol clarification bug. discover-tcp-transport, for example, currently transmits all properties of the contact object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant