Remove deprecated use of find_package(CUDA) #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccorm4
reviewed
May 23, 2024
CMakeLists.txt
Outdated
|
|
||
| enable_language(CUDA) | ||
| set_target_properties(kernel_library_new PROPERTIES LANGUAGE CUDA) | ||
| set_target_properties(kernel_library_new PROPERTIES CUDA_ARCHITECTURES "53;60;61;62;70;72;75") |
There was a problem hiding this comment.
Just for my own curiosity - any idea what the implications of this line not including Ampere+ (>=8.0)?
Does it mean this will be (a) JIT'd at startup, (b) not taking advantage of some newer arch-specific features, (c) unsupported on those archs, or (d) other?
There was a problem hiding this comment.
That's a great question that I don't know the answer to.
There was a problem hiding this comment.
Not sure what is the new variable name for it is, code defines the optimized kernel for the listed CC, arch defines the PTX generated which provides support for CC not listed above.
GuanLuo
previously approved these changes
May 23, 2024
Tabrizian
force-pushed
the
imant-deprecated
branch
from
d030469 to
f9e9a15
Compare
GuanLuo
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_package(CUDA) is deprecated.
https://cmake.org/cmake/help/latest/module/FindCUDA.html